Comments (10)
Hi @fisheva, thank you for your feedback! We will look into these issues soon and let you know once the fix is merged!
from theme-converter-for-vs.
Bug 1:
Describe the bug
"dropdown.background" also affects all background colors in the selection box. See the screenshots below for comparion. The selection background and current select option background in the Eva Light (added "dropdown.background": "#f1f4fb") are all the same. Make the selected texts hard to read.
Screenshots
Use Visual Studio default Light theme, screenshot.
To Reproduce
Steps to reproduce the behavior (after the reproduce steps of paragraph 1):
5,Switch the theme to Eva Light.
6,Click "Assets" → "Edit" → drop down selection box.
Expected behavior
The selection background and current select option background affects by "list.activeSelectionBackground" instead of "dropdown.background".
Impact
Because of this bug, I have removed "dropdown.background" option in the currently release of the official version of the conversion JSON, the area it affects currently displays the default theme colors.
Additional context
If after the repair, the selection background and current select option background is not affected by "list.activeSelectionBackground", please tell me which API it is. Thanks!
from theme-converter-for-vs.
Bug 2:
Describe the bug
"statusBar.background" affects both normal, building and debugging status bar background color.
Screenshots
Use Visual Studio default Dark theme, screenshot. It's building, and the status bar background color changed.
Use Eva Dark, screenshot. It's building, but the status bar background color didn't change.
To Reproduce
Steps to reproduce the behavior (after the reproduce steps of paragraph 1):
5,Switch the theme to Eva Dark.
6,Click tool bar "Build" → "Build solution".
Expected behavior
"statusBar.background" affects only normal status bar background color. "statusBar.debuggingBackground" affects both building and debugging status bar background color.
Impact
Because of this bug, Eva Theme for VS users can't see the color change of status bar background when building or debugging.
Additional context
If after the repair, the building and debugging status bar background color are not affected by "statusBar.debuggingBackground", please tell me which API it is. Thanks!
from theme-converter-for-vs.
Bug 3:
Describe the bug
The independently window title color is black both in Eva Dark and Eva Light. And I find no API can affect it's color. When the code window is displayed independently, the color of the title bar is hard to read in Eva Dark.
Screenshots
Use Visual Studio default Dark theme, screenshot.
Use Eva Dark, screenshot. The independently window title is hard to read.
Use Eva Test, screenshot. The independently window title color is still black.
(Eva Test is a theme I used to initially find the scope of the API. All APIs are set, but none of them are set to black.)
To Reproduce
Steps to reproduce the behavior (after the reproduce steps of paragraph 1):
5,Switch the theme to Eva Dark.
6,Drag and drop 'AssemblyInfo.cs' file to a independently window.
Expected behavior
The independently window title color is controlled by a generate JSON API.
Impact
This bug is reported by an Eva Theme user in this issue.
Additional context
After the repair, please tell me which API it is. Thanks!
from theme-converter-for-vs.
Bug 4:
Describe the bug
The border color of the currently selected input box and the background color of the selected text in the input box are affected by "foreground" API.
Screenshots
Use Visual Studio default Dark theme, screenshot.
Use Eva Dark(Set "foreground":"#0000ff"), screenshot. You can see all UI colors affected by "foreground" API.
To Reproduce
Steps to reproduce the behavior (after the reproduce steps of paragraph 1):
5,Switch the theme to Eva Dark.
6,Select some text in a input box.
Expected behavior
The border color of the currently selected input box and the background color of the selected text in the input box are affected by "list.activeSelectionBackground" instead of "foreground".
Impact
This bug does not affect the use, but affects the theme style.
Additional context
If after the repair, the border color of the currently selected input box and the background color of the selected text in the input box are not affected by "list.activeSelectionBackground", please tell me which API it is. Thanks!
from theme-converter-for-vs.
Hi @fisheva, for bug 2, I checked VS Code's behavior and seems like the status bar is not changing color during building and I think it might make sense for the converted theme to match VS Code's for better parity? Wondering what do you think?
!
For bug 1, 3 and 4, the fix is in #141.
The vs code API that controls the floating window title text is titleBar.activeForeground
when the window has focus and titleBar.inactiveForeground
when the window doesn't have focus.
For both text selection issues, the corresponding VS Code API is selection.background
.
Feel free to check if the fix matches your expectation and let me know if you have any questions! Thank you!
from theme-converter-for-vs.
Closing this bug as #141 is merged. If the fix did not meet your expectations, feel free to reactivate this bug. Thanks again for your feedback!
from theme-converter-for-vs.
Hi, @ketty! Very sorry for reply late, I have a lot of development tasks these days, only have time to deal with Eva Theme things on weekends.
I have a different opinion on the status bar color bug. Although Eva Theme for VS is converted from Eva Theme for VSCode, since the current service platform is Visual Studio, it should conform to the user habits of Visual Studio platform. Since the default Visual Studio theme status bar changes color during building, other themes are best to keep this feedback, just in a different color style. So I think there needs an option to set the staus bar color during building.
I pulled the latest code of theme-converter-for-vs today and want to update Eva Theme for VS. But I find that my Visual Studio license had expired...
I usually use VSCode for development, and use Visual Studio just to test Eva Theme for VS. Can I apply for an available license for both 2019 and 2022 ? (Some Eva Theme users still use VS2019). I appreciate for it!
The last question, a user left a bug report under my Eva Theme for VS Marketplace. I don't know how to deal with it and reply. Is this a bug caused by the conversion process?
from theme-converter-for-vs.
Hi @fisheva, thank you for your reply!
- For the status bar, in a long term, we will consider making a list of tunable controls for this kind of scenarios, so that users can have better control over the result. For now, I have made this branch: dev/ketyang/buildingstatusbar for the behavior that you are looking for:
statusBar.debuggingBackground/foreground
will control both debugging and building status bar colors in VS. Therefore, if you want, feel free to use that branch as an alternative. - The "VS.Cider.ComboBoxColor" issue that the user mentioned should be fixed by reconverting the theme with the latest converter.
- From what I know, @gracegtaylor is now looking at the license issue, so she might be able to provide more information on that.
from theme-converter-for-vs.
Hi @ketty, very thanks for solving my issues perfectly!
from theme-converter-for-vs.
Related Issues (20)
- Semantic Tokens? HOT 4
- Text in 'Git Changes' warning/error panel is not readable HOT 2
- AppCap Overview pages have the wrong colors HOT 1
- Solarized light: Unittest popup links are not readable HOT 2
- Incorrect main menu colours for inactive elements HOT 3
- Visual Studio shows bright line below tabs HOT 7
- Error List pane resize separator HOT 12
- Converted theme has the wrong colors (One Dark Pro Monokai Darker Reloaded Theme) HOT 12
- Line highlight in Visual Studio 2022 contains an outline instead of being flat
- Does still preview version of Visual Studio 2022 may affect the result? HOT 1
- Improvements to Contrast
- Button color api
- Not a bug - howsabout vice-versa?
- Small non-bug issue: Instruction video differs from instr. in text
- How do i delete a theme that got added to my visual studio? HOT 4
- Fails to parse working vscode theme HOT 1
- Discussion: The Many Configuration/Theme File Formats
- Themes are not working in Visual studio 1.7.9.0+ versions HOT 8
- The underline in vscode seems to have no effect on vs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from theme-converter-for-vs.