GithubHelp home page GithubHelp logo

Comments (12)

ketttY avatar ketttY commented on June 10, 2024 3

@Binaryify and @ryanbuening, thank you both for the clarification! I have created #148 to address this issue. Feel free to take a look and see if that meets your expectations! Thank you!

from theme-converter-for-vs.

ryanbuening avatar ryanbuening commented on June 10, 2024 1

Adding some clarification...this would occur on any pane docked there, not just the error list.

from theme-converter-for-vs.

ryanbuening avatar ryanbuening commented on June 10, 2024 1

That looks good to me. 👍

from theme-converter-for-vs.

Binaryify avatar Binaryify commented on June 10, 2024 1

thank for the fast response, I just re-generate a new vsix and it look great

from theme-converter-for-vs.

ketttY avatar ketttY commented on June 10, 2024

Hi @Binaryify, sorry for the delayed response, got some high-priority tasks that need to be addressed. I have tried reproducing this issue with One Dark Pro, One Dark Pro Darker, One Dark Pro Flat and One Dark Pro Mix, but none of them produced result like the one in the gif. I am wondering can you let me know which version of One Dark Pro you converted for the official extension? Thank you!

from theme-converter-for-vs.

Binaryify avatar Binaryify commented on June 10, 2024

@ryanbuening

from theme-converter-for-vs.

Binaryify avatar Binaryify commented on June 10, 2024

@ketttY I used this json file which generate from the vscode's generate from current theme command
https://gist.github.com/Binaryify/81fd565c1ac851b9cf55e852c77caa01

from theme-converter-for-vs.

Binaryify avatar Binaryify commented on June 10, 2024

also my vs's version is 17.2.3

from theme-converter-for-vs.

Binaryify avatar Binaryify commented on June 10, 2024

and it look like this in my vs
image

from theme-converter-for-vs.

ryanbuening avatar ryanbuening commented on June 10, 2024

I'm on 17.2.5

OneDark-Pro (Binaryify) theme:

image

Default Dark theme:

image

from theme-converter-for-vs.

ryanbuening avatar ryanbuening commented on June 10, 2024

@ketttY, could a similar thing be done (border) for the Tabs pane when tabs are placed on the left?...

image

from theme-converter-for-vs.

ketttY avatar ketttY commented on June 10, 2024

@ryanbuening, after checking, it looks like VS does not have a border token for that area, so for now the theme converter can't add a border there. Apologize for the inconvenience.

from theme-converter-for-vs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.