Comments (12)
@Binaryify and @ryanbuening, thank you both for the clarification! I have created #148 to address this issue. Feel free to take a look and see if that meets your expectations! Thank you!
from theme-converter-for-vs.
Adding some clarification...this would occur on any pane docked there, not just the error list.
from theme-converter-for-vs.
That looks good to me. 👍
from theme-converter-for-vs.
thank for the fast response, I just re-generate a new vsix and it look great
from theme-converter-for-vs.
Hi @Binaryify, sorry for the delayed response, got some high-priority tasks that need to be addressed. I have tried reproducing this issue with One Dark Pro, One Dark Pro Darker, One Dark Pro Flat and One Dark Pro Mix, but none of them produced result like the one in the gif. I am wondering can you let me know which version of One Dark Pro you converted for the official extension? Thank you!
from theme-converter-for-vs.
from theme-converter-for-vs.
@ketttY I used this json file which generate from the vscode's generate from current theme command
https://gist.github.com/Binaryify/81fd565c1ac851b9cf55e852c77caa01
from theme-converter-for-vs.
also my vs's version is 17.2.3
from theme-converter-for-vs.
and it look like this in my vs
from theme-converter-for-vs.
I'm on 17.2.5
OneDark-Pro (Binaryify) theme:
Default Dark theme:
from theme-converter-for-vs.
@ketttY, could a similar thing be done (border) for the Tabs pane when tabs are placed on the left?...
from theme-converter-for-vs.
@ryanbuening, after checking, it looks like VS does not have a border token for that area, so for now the theme converter can't add a border there. Apologize for the inconvenience.
from theme-converter-for-vs.
Related Issues (20)
- Semantic token not supported? HOT 4
- Semantic Tokens? HOT 4
- Text in 'Git Changes' warning/error panel is not readable HOT 2
- AppCap Overview pages have the wrong colors HOT 1
- Solarized light: Unittest popup links are not readable HOT 2
- Some conversion bugs HOT 10
- Incorrect main menu colours for inactive elements HOT 3
- Visual Studio shows bright line below tabs HOT 7
- Converted theme has the wrong colors (One Dark Pro Monokai Darker Reloaded Theme) HOT 12
- Line highlight in Visual Studio 2022 contains an outline instead of being flat
- Does still preview version of Visual Studio 2022 may affect the result? HOT 1
- Improvements to Contrast
- Button color api
- Not a bug - howsabout vice-versa?
- Small non-bug issue: Instruction video differs from instr. in text
- How do i delete a theme that got added to my visual studio? HOT 4
- Fails to parse working vscode theme HOT 1
- Discussion: The Many Configuration/Theme File Formats
- Themes are not working in Visual studio 1.7.9.0+ versions HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from theme-converter-for-vs.