Incorrect main menu colours for inactive elements about theme-converter-for-vs

[fwosar]

I checked out some more themes and this appears to be a universal issue that isn't limited to one theme. In fact, in the official video announcement, you can watch it live in action. Just pay attention to the context menu and the Copy, Cut, and Paste entries in particular.

I am genuinely surprised that seemingly nobody noticed this before.

[fwosar]

After doing some digging it turns out that Visual Studio Code uses opacity (0.4) to "grey out" inactive entries within the context and main menus, so there isn't a dedicated colour that could be converted. Therefore, the fix would probably involve setting the correct opacities for things like Environment/CommandBarTextInactive (and potentially other similar cases). In fact, after editing the theme manually and setting the opacity byte to 0x66, which is approximately 40%, the menus appear to be correct:

While making manual edits like that is certainly possible, even if not very straightforward, it would probably not be too difficult to just apply the opacity for this and similar elements automatically during the conversion.

[ketttY]

Hi @fwosar, thank you so much for your feedback! We will look into this issue and let you know once we have a fix for it!