GithubHelp home page GithubHelp logo

Comments (12)

kwisatzhaderech avatar kwisatzhaderech commented on June 10, 2024 2

I have exactly same issue with Visual Assist Dark Theme. The converted theme has the wrong colors compared to Visual Studio Code.

from theme-converter-for-vs.

nobushi95 avatar nobushi95 commented on June 10, 2024

I have the same problem with OneDarkPro.

from theme-converter-for-vs.

DavidBChristensen avatar DavidBChristensen commented on June 10, 2024

I just wanted to note here that I was having the same issue, then the thought occurred to me that it might only work for C#.
I opened a C# project, and sure enough that was the case.

So I guess what this issue is, is please support the C++ tokens as well.

from theme-converter-for-vs.

DavidBChristensen avatar DavidBChristensen commented on June 10, 2024

Okay, I took a look at the TokenMappings.json and I'll go ahead and add the Cpp* tokens. I don't use Resharper, so I'm not going to care about those.

At least the following need to be included as VS Tokens:

"Cpp Text Editor MEF Items&C/C++ User Keywords"
"Cpp Text Editor MEF Items&CppClassTemplateSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppControlKeywordSyntacticTokenFormat"
"Cpp Text Editor MEF Items&CppEnumSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppEventSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppFunctionSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppFunctionTemplateSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppGenericTypeSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppGlobalVariableSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppLabelSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppLocalVariableSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppMacroSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppMemberFieldSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppMemberFunctionSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppMemberOperatorSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppNamespaceSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppNewDeleteSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppOperatorSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppParameterSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppPropertySemanticTokenFormat"
"Cpp Text Editor MEF Items&CppRefTypeSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppStaticMemberFieldSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppStaticMemberFunctionSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppStringDelimiterCharacterSyntacticTokenFormat"
"Cpp Text Editor MEF Items&CppStringEscapeCharacterSyntacticTokenFormat"
"Cpp Text Editor MEF Items&CppSuggestedActionFormat"
"Cpp Text Editor MEF Items&CppTypeSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppUDLNumberSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppUDLRawSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppUDLStringSemanticTokenFormat"
"Cpp Text Editor MEF Items&CppValueTypeSemanticTokenFormat"
"Cpp Text Editor MEF Items&ReSharper C++ Class Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Struct Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Enum Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Union Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Namespace IdCpp Text Editor MEF Items&entifier"
"Cpp Text Editor MEF Items&ReSharper C++ Local Variable Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Parameter Variable Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Global Variable Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Concept Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Class Field Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Struct Field Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Static Field Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Enum Enumerator Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Union Member Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Typedef Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Global Function Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Member Function Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Static Member Function Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Overloaded Operator Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Template Parameter Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Dependent Name IdCpp Text Editor MEF Items&entifier"
"Cpp Text Editor MEF Items&ReSharper C++ Preprocessor Macro Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Preprocessor Macro Parameter Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ UE4 Reflection Specifier Identifier"
"Cpp Text Editor MEF Items&ReSharper C++ Doxygen Command"
"Cpp Text Editor MEF Items&ReSharper C++ String Literal"
"Cpp Text Editor MEF Items&ReSharper C++ Character Literal"
"Cpp Text Editor MEF Items&ReSharper C++ Integer Literal"
"Cpp Text Editor MEF Items&ReSharper C++ Float Literal"
"Cpp Text Editor MEF Items&ReSharper C++ UE4 Ini File Section"
"Cpp Text Editor MEF Items&ReSharper C++ UE4 Ini File Key"
"Cpp Text Editor MEF Items&ReSharper C++ UE4 Ini File Value Property"

from theme-converter-for-vs.

DavidBChristensen avatar DavidBChristensen commented on June 10, 2024

Okay, I finally got back home and did this. It works good enough for me to make a .vsix from my fork.

from theme-converter-for-vs.

zx-lhb avatar zx-lhb commented on June 10, 2024

oh, I have the same issue, it looks different in visual studio compared to vscode when using cpp. can it support cpp? please, i really love the dracula theme in vscode and i want to use it when editing cpp.

from theme-converter-for-vs.

ismaarino avatar ismaarino commented on June 10, 2024

Same issue on c++ files, with the Railgun theme

from theme-converter-for-vs.

Dangcaominh avatar Dangcaominh commented on June 10, 2024

Same issue on C++ file, C, xml, xaml and razor file with Cyberpunk 2077 theme.

from theme-converter-for-vs.

Dangcaominh avatar Dangcaominh commented on June 10, 2024

Following DavidBChristensen's guide, I have succeeded in making it work for C++. But can anyone tell me how to get the VS Token like him ?? I would like to get all the VS token for all the language to further develop my theme. Many thanks!

from theme-converter-for-vs.

aremmell avatar aremmell commented on June 10, 2024

Can we get some activity on this? Lots of C++ developers out here stuck using VS2022 (against our will) for work and would really like at least the visual comforts of VS Code whilst we use our bloated IDE from 2008.

@DavidBChristensen maybe you can open a PR if you've figured out all the correct mappings? And perhaps you could reply to @Dangcaominh about how you found those mappings?

from theme-converter-for-vs.

DavidBChristensen avatar DavidBChristensen commented on June 10, 2024

Sure, I'll make a PR for what I've got.
Unfortunately, I can't remember where I got those tokens from. I'll take a look later to see if I can "re-discover" that.

from theme-converter-for-vs.

aremmell avatar aremmell commented on June 10, 2024

Sure, I'll make a PR for what I've got. Unfortunately, I can't remember where I got those tokens from. I'll take a look later to see if I can "re-discover" that.

There's some in TokenMappings.json, but definitely not the entire list you posted. I spent 3 hours manually copying hex color codes into that block since Microsoft doesn't care about C++ anymore 😭

from theme-converter-for-vs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.