GithubHelp home page GithubHelp logo

Comments (7)

ross avatar ross commented on July 4, 2024

Support for Route53's ALIAS type was expected to start managing the records and thus delete un-configured (unmanaged) record. That probably should have been called out in the changelog and for that matter the release probably should have bumped a major version now that I think about it.

Not 100% sure off-hand what needs to happen to get dump to support the special record types, that's an oversight. Will look into that.

from octodns-route53.

ross avatar ross commented on July 4, 2024

octodns/octodns#924 should get dump supporting 3rd party/dynamically registered types.

There were oversights/bug(s) in the way of dump support for Route53's alias type. Provider._processed_desired_zone was doing its own type in provider.SUPPORTS check rather than using provider.supports(record). There are a few providers that already did extra logic in supports that _process_desired_zone wouldn't utilize.

Once that was fixed, YamlProvider needed to override that method and say that it always supports everything via return True.

If you check out that branch you should be able to get a dump with all of the Alias records included. I'm going to do some manual testing of that to verify as well.

So as for next steps for you there's two possible paths:

  1. Assuming this works, dump all the missing records and either replace your configs with the dumps or pull the aliases out into your configs and have them be managed going forward
  2. If you'd rather just leave those record unmanaged you should be able to configure a TypeRejectlistfilter and tell it to ignore the Route53Provider/ALIAS type.

I'm still trying to decide what the best course of action is around the CHANGELOG and version numbering...

from octodns-route53.

ross avatar ross commented on July 4, 2024

Verified a dump with an Route53Provider/ALIAS record configured in the UI worked:

alias:
  ttl: 942942942
  type: Route53Provider/ALIAS
  value:
    evaluate-target-health: true
    hosted-zone-id: null
    name: ''
    type: A

Route53's ALIAS type doesn't support ttls so that value is a default/sentinal value implemented in the provider. You can omit it and let the default value from the YamlProvider take effect. Either way it'll be ignored.

from octodns-route53.

ross avatar ross commented on July 4, 2024

Example of the ignore if you want to go that route:

...
processors:
  ignore-r53-alias:
    class: octodns.processor.filter.TypeRejectlistFilter
    rejectlist:
      - Route53Provider/ALIAS

zones:
  exxampled.com.:
    sources:
      - config
    processors:
      - ignore-r53-alias
    targets:
      - route53

from octodns-route53.

ross avatar ross commented on July 4, 2024

octodns/octodns#924 has merged so it can be pulled with the master branch there. Not sure when the next release will be cut so no timeline there.

from octodns-route53.

petelah avatar petelah commented on July 4, 2024

Awesome work @ross! I'll give this a try.

from octodns-route53.

github-actions avatar github-actions commented on July 4, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

from octodns-route53.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.