GithubHelp home page GithubHelp logo

Comments (2)

ross avatar ross commented on June 26, 2024

Unfortunately it's been a long time since a release was cut and there's a decent chunk of changes diff-wise, but there hasn't been ALL that much change to actual code. A refactor does unfortunately complicate seeing that, but as the WIP changelog indicates there's been no real changes.

v0.0.5...main

I don't see anything directly related to evaluate-target-health so what's changed may lie elsewhere. I'll see if I can reproduce.

from octodns-route53.

ross avatar ross commented on June 26, 2024

Been a minute since I made use of git bisect, but it worked perfectly here.

$ git bisect start
...
$ git bisect good v0.0.5
...
$ git bisect bad HEAD
...
$ git bisect good
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[775a760bdc8fd5d0437f453acfb2901900f6c9de] Convert _Route53AliasValue to dict-based
...
$ git bisect bad
775a760bdc8fd5d0437f453acfb2901900f6c9de is the first bad commit
commit 775a760bdc8fd5d0437f453acfb2901900f6c9de
Author: Ross McFarland <[email protected]>
Date:   Tue Oct 25 19:09:15 2022 -0700

    Convert _Route53AliasValue to dict-based

 octodns_route53/record.py              | 41 ++++++++++++++++++++++++++++------
 tests/test_octodns_provider_route53.py | 14 +++++++-----
 2 files changed, 42 insertions(+), 13 deletions(-)

PR that made the change: #41

from octodns-route53.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.