opensim-org / conda-opensim Goto Github PK

@kidzik it's awesome that you've created this conda package. Here are my comments (mostly questions). No need to respond to them now; we can discuss in person, etc.

1. Should we depend on the existing Simbody package?
2. I think it's fine to not create a separate package for BTK.
3. You can use OPENSIM_COPY_DEPENDENCIES to avoid needing to copy BTK/Simbody manually.
4. We should chat about what installation layout makes sense for conda; we have two options (OPENSIM_INSTALL_UNIX_FHS=on/off), especially on Windows.
5. We should document this installation option in opensim-core's README, and eventually also document it on Confluence.
6. Should we install OpenSim's command-line tool, opensim-cmd?
7. Should simbody-visualizer should be installed in libexec/simbody or bin? It's somewhat built into the Simbody libraries that its location relative to the Simbody libraries does not change.
8. We should run the python tests after the build is complete.
9. Should we support other distribution mechanisms, namely binary wheels on PyPI?
10. Should we continue distributing the python build in the OpenSim GUI distribution on SimTK.org?
11. Should the conda package also install examples? Is this typical with conda package? How do conda users typically obtain examples?
12. What's the process for getting the package into the conda-forge channel, and when should we start that process?
13. Does conda have guidelines for python packages that contain C/C++ libraries? Would it ever make sense to have separate packages for the C++ library and the python package?
14. Do we expect C++ users to be able to use the C++ libraries in the package? That is, are the CMake config files and the headers installed properly?

cc @moorepants

Issue reported on user forum
https://simtk.org/plugins/phpBB/posting.php?mode=reply&f=91&t=15999&sid=4c36d5d568641f0b859cef704000c9c9
opensim-moco package on osx is stale, and on linux doesn't exist.

This will be necessary to run moco solutions using jupyter notebooks

Hello,

I've been reinstalling my whole Opensim and anaconda ecosystem and I've encountered this issue when trying to use the latest conda package of opensim (4.4).

Configuration

• OS: Windows 11 x64
• Anaconda distribution: 2022.05 (https://repo.anaconda.com/archive/)
• Opensim software: 4.4 (normally not used at all for the conda package (?))
• Opensim conda package: 4.4
• Conda environment used: default one with python3.8

Issue description

1. I installed Anaconda as root/admin, it gave me no issue with installing and using the opensim conda package.
2. I needed to install Anaconda as user only, so I uninstalled the root version, made sure every environment path is gone, then reinstalled the distribution as a user. When reinstalling the opensim conda package, I got the following:
   NameError: name 'DLL_PATH' is not defined from the file init.py of the conda package in my environment.

Temporary workaround

I checked and the issue seems to be that os.path.join(sys.prefix, 'conda') is c:\Users\user_name\anaconda3\envs\opensim\conda which shouldn't be that since it doesn't exist because the conda executable is not environment-specific.
I replaced the line os.add_dll_directory(DLL_PATH) by os.add_dll_directory("c:\Users\user_name\anaconda3\Library\bin") and now everything works perfectly.

However, I don't understand why the "DLL_PATH" is not defined.
Is this workaround the good way to resolve it?

Thank you.

due to upgrade on Apr 27 2023
https://medium.com/google-colab/colab-updated-to-python-3-10-27eb02daa162

Per discussion with @AlbertoCasasOrtiz this will be needed to create and test the opensim-moco package and to test future integrations/upgrades. Particularly relevant since ci will stop supporting 18.04 and associated compilers in the near term.

I think you should use brew install freeglut and then remove it from meta.yaml

Hi,

I have built the OpenSim conda packages for windows, linux, and osx platforms (all x64). It looked like a good idea to share it here as it was missing a build for OpenSim4.1.

Link to conda packages. Please feel free to test them.

If it is okay, then I can send a pull request. :)

Best,
Vishal

Comparing older versions that worked out of the box to new problematic builds shows:
new info/about.json
"conda_build_version": "3.21.9",
"conda_private": false,
"conda_version": "4.13.0"
vs. old info/about.json
"conda_build_version": "3.21.8",
"conda_private": false,
"conda_version": "4.12.0",

Maybe we can force conda version and conda build version on ci

Is it possible that Conda users might think a package named "opensim" also contains the GUI? I'm fine leaving the name as "opensim", but I wanted to bring this up for discussion.

Platform: Ubuntu 22.04 (through Windows Subsystem for Linux)
Python version: 3.9
Numpy: 1.20.2

I installed the conda package into my conda environment, and while import opensim loads fine inside a Python interpreter, the opensim-cmd command line tool is notfound. I searched the Anaconda directories and found the OpenSim headers, include files, and Python modules but no opensim-cmd executable or any \bin folder associated with the OpenSim package.