GithubHelp home page GithubHelp logo

Comments (2)

McMannaman avatar McMannaman commented on August 11, 2024

There's additional validation steps for the event, that include also transaction matching on L1 and ensuring all the balances are in place before actual card topup occurs. Based from the description, though, if this event would be the only source of truth for the topup that would be a high severity.

from 2022-10-mover-judging.

Evert0x avatar Evert0x commented on August 11, 2024

From a pure solidity perspective it is not an attack vector if an event can be emitted with arbitrary calls. However, we like to take the business logic into account to a certain degree, but considering the protocol put the following text in their readme:

https://github.com/sherlock-audit/2022-10-mover/blob/main/cardtopup_contract/readme.md

The settlement process on L1 is off-chain and out of scope of the smart contracts.
If the proper event would be generated for card top-up, it would be further processed
by backend infrastructure.

We don't assign a medium or high severity to this issue.

from 2022-10-mover-judging.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.