GithubHelp home page GithubHelp logo

ak1 - _processTopup will not work when SYNAPSE bridge is paused. All other process could not function. about 2022-10-mover-judging HOT 1 CLOSED

sherlock-admin avatar sherlock-admin commented on August 11, 2024
ak1 - _processTopup will not work when SYNAPSE bridge is paused. All other process could not function.

from 2022-10-mover-judging.

Comments (1)

McMannaman avatar McMannaman commented on August 11, 2024

First, we cannot rely on each bridge swap contract implementation details (they're subject to change) thus, we don't want to include check for pausing of the contract. If bridge is disabled this way, tx would revert and that would be not very good, but expected and proper outcome, no funds lost.

second, as the recommendation states, the pause mechanism was already implemented
HardenedTopupProxy.sol L299
require(paused == false, "operations paused");

Therefore this should not be considered an issue.

from 2022-10-mover-judging.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.