GithubHelp home page GithubHelp logo

WATCHPUG - Slippage tolerance for Synapse should not be specified as constant values of `0.95`, `0.91` about 2022-10-mover-judging HOT 1 CLOSED

sherlock-admin avatar sherlock-admin commented on August 11, 2024
WATCHPUG - Slippage tolerance for Synapse should not be specified as constant values of `0.95`, `0.91`

from 2022-10-mover-judging.

Comments (1)

McMannaman avatar McMannaman commented on August 11, 2024

#103
is more duplicate of
#53

this issue has no duplicates as far as I saw through the issues.

This is a good deep dive into the interaction btwn TopupProxy and particular bridge ABI.
Yes this is a compromise. As we work with stablecoins and always set the in/out token
as USDC (or its equivalent) these values serve as a kind of sanity checks and we expected the
actual slippage to be much tighter. So if these thresholds are not met, bridging would not
happen which suits us (the slippage is way off and we may consider switching to another bridge or
otherwise somehow investigate the situation.

But we don't want to set it too tight to get things reverted, or complicate the flow for the user to
manage slippage or deal with reverted txs because of slippage. If the slippage is high for stablecoins,
we consider another bridge provider. Hope this explains our point.

We very much appreciate the effort done to underpin this with a precise particularity.

from 2022-10-mover-judging.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.