spatie / commonmark-highlighter Goto Github PK

Hi
Is it possible to add .hljs class even to blocks with unsupported languages. Currently, unsupported languages (like blade, vue ..etc) display without a background when applying a theme. This will confuse the reader as they appear just like a regular text.

This is without apply the class:

This is with the class applied:

There's an issue for it, but the bottom line is new installations of this library will pull in a version of the highlighter which has an infinite loop when rendering JS code blocks.

I have a branch that fixes it, which I have submitted as a PR; but you might want to tag an older version in the meantime...

If you try to highlight a specific line in combination with an emoji, the emoji will not be shown anymore:

    ```php{2}
    // ✅ ...
    $isUserPending = $user->isStatus('pending');
    ```

Without the {2} the emoji is shown correctly:

    ```php
    // ✅ ...
    $isUserPending = $user->isStatus('pending');
    ```

Have you an idea what this is about @allejo?

PS: Here some info about how I set up the converter:

        $environment = Environment::createCommonMarkEnvironment();
        $languages = ['html', 'php', 'js', 'shell', 'shell'];

        $environment->addBlockRenderer(FencedCode::class, new FencedCodeRenderer($languages));
        $environment->addBlockRenderer(IndentedCode::class, new IndentedCodeRenderer($languages));

        $commonMarkConverter = new CommonMarkConverter([], $environment);

        return $commonMarkConverter->convertToHtml($codeExample);

Commonmark v1.0.0 changes the League\CommonMark\Block\Renderer\FencedCodeRenderer to be a final class, so it can’t be extended anymore.

hi there,
I don't know if it's package related, but any idea why the "script" tag isn't highlighted correctly?

The code for this (picture):

I save the textarea directly to the db from SimpleMde with markdown data, and on frontend I use github.css style for this example, and use {!! !!} tags to render.

With php I don't have any problem, fully colorize the opening tag.

The CommonMark spec allows for any arbitrary content to exist in the info string of a code block. Would you be open to adding support for highlighting specific lines of code within said code block?

```html{2}
<div>
  <p>I wish I wish I was a fish</p>
</div>
```

Proposed Syntax

• html{4} - highlight the 4th line of the code block
• html{4-5} - highlight the 4th through 5th lines of code
• html{1,4-5} - highlight the 1st and 4th through 5th line of code separately