teekaytai / pe Goto Github PK

The email [email protected] appears to follow the rules on the required format but it still gets rejected by the app

Steps: Run `add n/Thomas p/12345678 e/[email protected] m/1 r/100

The error message provided when a prefix is incorrect is misleading.

In the example below, I'm attempting to edit the name and birth month of a customer, but misremembered the prefix for birth month as b instead of m. The error message instead suggests the name is incorrectly formatted. This can be an inconvenience for users since the error message is misdirecting them, making it harder for them to figure out the problem with their command.

Steps: Run edit p/12345678 n/Thomas b/10

The UG does not seem to explain the ability to remove tags from customers by running an edit command with an empty t/ prefix. This is a fairly non-obvious behaviour that I don't think a user can figure out on their own. Without this, a user would need tro delete a customer and add it in again to remove tags.

In the help window, the link to the user guide appears to be a link to a file on github instead of the actual user guide website. This may hinder user-friendliness a bit for users not familiar with github.

Steps: Run the help command to pull up the help window

Testing edit

In the UG in the "Notes about the command format section", there is an explanation of what happens if multiple of the same parameter is included when only one is expected. However the example provided (phone number p/) is an example where the parameter is expected multiple times (in the edit command), so the example can be misleading.

This violates the pdf-friendly constraint

Below is one example of an expandable panel holding examples of the incr command

The diagram is very small and very hard to read even when zoomed in to fill the width of the screen

The find command in the UG is missing a "..." after [MORE_KEYWORDS] to indicate you can have more than 2 keywords searched. The find format message in the actual app does have the "..."

Because of the inclusion of many large images, it was fairly cumbersome trying to understand how to use the commands since I needed to scroll over multiple pages to see the format and then see the examples. For instance, the find command instructions span over 12 pages in total. The images themselves don't seem to add much value either.

There is a missing space between the email and the p/ prefix in the error message, causing the example command to be invalid

Steps: Run edit with no further arguments

The UG states that parameters can be supplied in any order but actually the order matters in certain cases like in the example below

There does not seem to be any explanation in the UG of why two phone numbers can be input into an edit command. This confused me at first since I thought one phone number would override the other. I feel the reader would benefit from a note somewhere that the first phone number is used to identify the person to edit and the second one is the replacement phone number

Including a calculator seems to not fit well together with the other features of the app. To quote from the UG, the purpose of bobaBot is "a cheap & easy-to-use desktop application for managing bubble tea shop customers’ membership details". A calculator does not help with managing the information and it is likely any users' computer would already feature a more powerful calculator app

Restricting a phone number to being 8 digits seems too restrictive since some people would have phone numbers that are a different number of digits long, eg. people with foreign phone numbers. There is no easy workaround to get around this problem should a user need to enter such a phone number

If I understand correctly, the images in bobaBot on the right do not seem to serve any function?
If they aren't meaningful for the app, perhaps they should have been removed to allow more space to hold more useful items instead, like make the customer info area larger or to hold the calculator.

Notice the image takes up more space than the customer info

The DG claims one NFR is that the app "should work when some data is missing or inaccurate". The actual app however does not allow fields like birth month to be missing when adding customers

If the user has a small screen, long names overflow and cannot be viewed fully

The message refers to a Java class instead of just saying undo