Detailed data of guild members about sf-api

[the-marenga]

The only way to fetch detailed data of other players is with the ViewPlayer command. Thats how the game itself does it for guild members, hall of fame entries, arena battles and so on. All just use the ViewPlayer command in the game. The data fetched should contain all data the game has about the player (equipment, attributes, album count, fortress, etc.).

If I remember correctly, the value for the portal count the server sends is bad/wrong in some cases and I prefered to have no value, instead of a wrong value, so I commented that part of the parsing out until I know what makes the game send a wrong value:

sf-api/src/gamestate/social.rs

Line 307 in abbb899

// op.portal_hp_bonus = (data[253] >> 16) / 256;

If you need that value, I can check up on that problem again and make sure that value gets parsed correctly

[the-marenga]

Yes, because you can use the ViewPlayer command with the player_id, or the username. As a result, there also has to be a way to get the fetched result from the gamestate with the player_id and the username. Both of these ways are provides with the lookup_name() and lookup_pid() methods on OtherPlayers. If the underlying fields were public, you could easily create situations, where the lookup is no longer in sync with the vec, that contains the players and thus return you the wrong result when calling the lookup methods

[Sempoinus1]

Thanks! Everything is resolved now. I'll take a look at the portal too maybe I'll figure something out.

[Sempoinus1]

Thanks! That helped a lot!

Btw, is there any reason for

sf-api/src/gamestate/social.rs

Line 54 in abbb899

other_players: Vec<OtherPlayer>,

this to be private?