valora-inc / wallet

The official repository for the Valora mobile cryptocurrency wallet.

Valora Mobile App

Valora is a mobile wallet focused on making global peer-to-peer payments simple and accessible to anyone. It supports the Celo Identity Protocol which allows users to verify their phone number and send payments to their contacts.

Integrate with Valora

Connect your Dapp to Valora using WalletConnect.

See also deeplinks.md for integrating with Valora using deep links.

Build Valora Locally

To setup Valora locally, follow setup instructions.

Repo Structure

The repository follows the default React Native Android and iOS app structure.

Code owners can be found in .github/CODEOWNERS.

Contributing

We welcome contributions in the form of Issues and PRs. Please read CONTRIBUTING.md first!

Community

Have questions or need help? Join our Discord Community.

wallet's Issues

Users SBAT start geth multiple times without restarting app

Expected Behavior

Geth can be started and restarted without having restart the app or returning gas fee errors

Current Behavior

After starting geth a second time in one app session, view and state-changing functions both return a gas fee error ("0 is below minimum gasPrice"). The gasFee of 0 comes from this line as FallbackGasPriceMinimum , which is 0, is returned as the smart contract is not deployed. It is not clear why the smart contract is not deployed, as it gets an up to date current block.

As a work around right now, the app requires users to restart the app if they are starting geth more than once in a session (ex: start by using Forno, then start geth, back to Forno, start geth agaun and restart. Or start using geth, turn on Forno, turn back on geth and restart)

Update test libs to keep to new RN-test-lib recommendations

Expected Behavior

Keep to guidelines and recommended additional packages:
https://kentcdodds.com/blog/common-mistakes-with-react-testing-library

Current Behavior

Some things we do are considered mistakes

Ultralight sync takes too long on low-end devices

Expected Behavior

App syncs in under a minute on any network of any age. Not sure this is possible but it should be the goal.

Current Behavior

The time to first sync for a fresh app install on a network that's over a week old is longer than one would intuitively expect given our 'Lightest' syncing strategy. On AlfajoresStaging, which uses 10 minute epoch lengths, the sync takes over 2 minutes even when the network is only ~ 2 weeks old.

Persist certain values like phone number salts between app installs

Expected Behavior

Keep salts in storage to persist between app installs:
https://developer.android.com/guide/topics/data/backup.html
https://developer.apple.com/documentation/security/keychain_services

Current Behavior

All info is lost when app is uninstalled, including keys and salts. We should persist some useful info like the salt lookup results.

Migrate from TSLint to ESLint

As https://github.com/palantir/tslint#tslint states: "TSLint will be deprecated some time in 2019", so we should migrate to ESLint. Also, after typescript version update celo-org/celo-monorepo#2196 we are now using ^3.7.3, but our TSLint using ~3.4.0. This resolves to discrepancy between the developing process and actual build.

As a short term solution we can update TSLInt to 6.0.0-beta1, where typescript version is ~3.6.3 to shorten the difference.

Local currency amounts can round to less than 0.01

Expected Behavior

https://celo-org.slack.com/archives/CL7BVQPHB/p1585084184243100

Current Behavior

Right now, the app rounds to 0. The actual amount in this case is 0.0012

User "name" input does not do any format checking for correctness

Frequency: 100%
** Repro App version:** Celo Integration Wallet build v1.8.2 (39)
**Repro on device:**iPhone XS max (13.1), iphone 6+ (12.4.5)

Repro Steps:

1. Launch app
2. Select the language and navigate to the Account info screen.
3. Enter white space on the Full name screen.

*Current Behavior: User is able to proceed to the term screen with entering white space on the Full name required field.

Expected Behavior: User should be able to navigate to next screen with entering white space on required fields.
Impact Bad user experience
Attachment: FullName_BlankIssue.mp4 (Bug Observed at 07 sec)

[Wallet] Light client timeout issue fetching state on older devices

Expected Behavior

Users with older Android devices can fetch balances without timing out

Current Behavior

On older Android devices, seeing a timeout issue when fetching state. For example: Error fetching balance:Returned error: execution aborted (timeout = 5s). Only happens sometimes

See logs here: celo-org/celo-monorepo#3280 (comment)

Note that this caused celo-org/celo-monorepo#3280 to be observed, but that verification issue is tracking reveal-related issues. This timeout issue does not seem to be specific to verification

Change Celo Dollars to local currency in notifications

Expected Behavior

In Incoming and Outgoing payment requests, as well in Escrowed Payments user sees local currency.

Current Behavior

In Incoming and Outgoing payment requests, as well in Escrowed Payments user sees Celo Dollars.

Related celo-org/celo-monorepo#1808

[Wallet] Difficult reading small text in backup phrase flow (UX issue)

Expected Behavior

Users that may have cracked screens or dim brightness should be able to read text and complete backup phrase quiz on their phones.

Current Behavior

Given the context of:

• Cracked screens very common
• Poor eyesight / lack of corrective vision
• Screens on dim setting to save battery

Small text in the app is difficult to read, particularly in the backup phrase flow and quiz.

“Unknown” text is shown when user getting the escrew payment or adding amount from Add and Withdraw option

Frequency: 100%
** Repro App version:** Celo integration build v1.8.2 (36)
Does not repro: app store build v1.8.0
**Repro on device:**iPhone XS max (13.1), iphone 6+ (12.4.5)

Repro Steps:

1. Launch app and sign up in the app
2. Make sure the user has verified the phone number.
3. Make sure user is got the escrow payment
4. Observe Unknown text is shown.
5. Add amount form Add & Withdraw option.
6. Observe Unknown text is shown.

Current Behavior: Unknown text is shown
Expected Behavior: Appropriate text should be shown instead of Unknown text.
Attachment: UnknownText.png

[Stretch] Test full node discovery in the wallet

Expected Behavior

Ensure the wallet can connect to full nodes

[Wallet] Exchange rate data should be fetched directly from `MedianUpdated` events via eksportisto

Expected Behavior

Rate matches centralized exchanges and is based on MedianUpdated event via eksportisto

Current Behavior

The exchange rate is queried from the Exchange contract. It varies based on the amount, so we estimate it with a small amount. Difference in gold vs dollar rate due the Exchange's forced spread of 0.5%

Misc QR Code and Send Improvements

Expected Behavior

• QR code screen in the app includes:

• Profile image;

• Account name;

• QR code;

• Short account URL;

• Shared QR code image (the one that is being sent via sharing button at the top right corner) includes:

• Profile image;

• Account name;

• QR code;

• Short account URL;

Design (Mockup below)

Current Behavior

• QR code screen includes phone number and code itself is smaller than on the mock up;
• Only QR code as an image is being sent when shared.

Implement minimal contacts import on iOS to make it faster

Expected Behavior

getMinimal should be implemented on react-native-contacts for iOS. And used by the wallet.

Current Behavior

Contacts retrieval passes all data through the RN bridge and could be made faster by passing only the info we need.

According to @jmrossy there was a 3-5x import speedup on Android.

Users SBAT cancel a dappkit flow

Expected Behavior

The dapp should receive the appropriate failure response

Current Behavior

Even if you cancel the flow, the dapp still gets the data

[Wallet] Using non-global namespaces for error messages is broken

Expected Behavior

When using non-global namespaces for error messages, the alert messaging works as expected.

Current Behavior

When attempting to use any namespace that is not global, the error message does not display correctly. This is likely happening because the showError function in mobile/src/alert/actions.ts forces use of the global namespace.

As an example, SMS_ERROR in mobile/src/app/ErrorMessages.ts renders as "walletFlow5:SMSError" instead of "Error sending SMS".

Remove InviteDetails of failed transactions

Expected Behavior

When an invite transaction fails, the InviteDetail associated with that transaction should be deleted of the user's a device. This will help us avoid issues with storing several conflicting invite details for one invitee.

Current Behavior

InviteDetail is stored prior to any of the necessary transactions being sent and are not removed if the transactions fail.

Relevant Files

mobile/src/invite/saga.ts

Revoke Phone Number in app

What's important about this?

Atm there is no way in the Valora app for the user to revoke/change/update their phone number.

What is "done"?

There is a new feature in the settings that allows user to revoke/add/change their phone number

What's involved in doing this work?

Please see Phone number management part of the design: figma for further details.

Wallet jest tests should cover both iOS and Android

Expected Behavior

Jest tests should cover both iOS and Android.
See https://blog.expo.io/testing-universal-react-native-apps-with-jest-and-expo-113b4bf9cc44
And cover snapshots too.

Current Behavior

Jest tests only cover Android.

Replace Google-libphonenumber with libphonenumber-js

Expected Behavior

Use https://github.com/catamphetamine/libphonenumber-js 130 kilobytes (55 kB code + 75 kB sufficient metadata) In @celo/utils package

Current Behavior

Google Libphonenumber is a very big package 530 kilobytes (330 kB code + 200 kB full metadata). and is used by @celo/utils which means it can be included in packages very easily without us noticing.

Address should have their own type instead of using strings

Expected Behavior

Strings should be handled with it's own type.

Current Behavior

Currently, strings are used to represent hex addresses. This generates a problem to developers identifying types and also can cause some validation issues, as any string will [ass the static TS check.

Valora should use a performant QR scanner on lower end devices

Expected Behavior

Investigate performance gains of something like https://github.com/ekreutz/react-native-barcode-scanner-google which uses Google's barcode API .

Example provided for multi-platform support.

Current Behavior

Using RNCamera for QR scanning.
App crashes when scanning on lower-end devices.

[Wallet] Adjust time screen moves to Dashboard, when wallet is not created

Expected Behavior

Adjust time screen moves to "Create wallet" flow, when wallet is not created

Current Behavior

Adjust time screen moves to Dashboard, when wallet is not created

User is not able to edit an amount which are before decimal point value if user has entered 2 decimal value in Amount field while proceed for payment.

Frequency: 100%
App version: Staging build v1.5.2 (104694505)
Repro on: Samsung Galaxy A8+(8.0.0), Samsung Galaxy Note 5 (7.0)

Repro Steps:

1. Launch the app.
2. Tap on “+” tab.
3. Select any Celo contact user.
4. Enter a two decimal value with two amounts. for example 12.34.
5. Move to cursor to after 1
6. Tried to enter value and observed.

Impact: User is blocked to edit an amount.
Investigation: Issue does not repro if user has entered only 1 decimal value.
Current Behavior: User is not able to edit an amount
Expected Behavior: User should be able to edit an amount.
Attachment: Android_DecimalValue.mp4 (Bug observed at 14 sec)

Add component tests for pincode handling

Expected Behavior

e2e tests handle different pincode situations

Current Behavior

no e2e coverage

Error should not trigger when a user enters a decimal as an amount

Frequency: 100%
iOS App version: iOS Testflight build : v1.8..0 (31), Android build v1.8.0
Repro on devices: Vivo 1606 (6.01), Google Pixel XL (8.1), Iphone 6+ (12.4.5)
Testing account: 4322573132/Backup key

Repro Steps:

1. Launch the app and Login with test account
2. Tap on Gold tab.

3. Tap o Buy button

4. Tap on Switch to USD link.
5. Enter dot enter amount (USD) field.
6. Observe

Current Behavior:“Not enough celo dollars…” error message is shown
Expected Behavior: Error message should not shown
Investigation:

1. Issue does not repro when user Enter Amount in “Amount (USD)” filed.
2. User is able to proceed for exchange even after showing error message

Impact: User may get confused as they have balance however facing “Not enough celo dollars…” error message.
Attachment: ErrormessageGoldTab.mp4

Implement lockout on PIN attempts if there are several incorrect attempts

Expected Behavior

see discussion here: celo-org/celo-monorepo#2574 (comment)

Custom pin screen is currently vulnerable to brute forcing as we implement no lockout, explore options for this.

Current Behavior

PIN can be attempted without penalty until correct

CELO chart performance and usability

Expected Behavior

Chart loads quickly and gives the user the ability to view price changes over different time ranges.

• Performance improvements
• Ability to select different time ranges

Blockchain-api changes are required.

Current Behavior

Slow and flaky, especially on medium-to-weak connections. Inability to view price changes over dynamic time ranges.

Prevent abuse of Remind functionality

Expected Behavior

When a user has been requested for payment - we should limit amount of time they could be reminded by requester via push notifications.

Current Behavior

Once celo-org/celo-monorepo#1744 is done - requester can "remind" requestee any amount of times (send push notifications).

Related celo-org/celo-monorepo#1744

Explore using React-Native-SMS for Android

Expected Behavior

We use react-native-sms to send SMS for both Android and iOS. Not 100% sure it is possible given our Android build configurations but the package claims to support both Android and iOS.

Current Behavior

We are using an Android specific package (react-native-send-intent) for Android SMS messages and a package with capabilities for both Andorid and iOS (react-native-sms) for iOS.

Relevant Files

Primarily mobile/src/inivite/saga.ts but there may be other places we are using it.

[Wallet] Exchange users SNBAT proceed with stale cUSD/gold rate

Expected Behavior

Exchange UI blocks until new rate and tobin tax are fetched. Similar to fee approach with send transactions here https://github.com/celo-org/celo-monorepo/blob/master/packages/mobile/src/send/SendConfirmation.tsx#L180

Current Behavior

Users can proceed with stale rate

[Android] More than 2 decimal point is shown after payment request amount on “Payment Request” section when receiver receives a payment request if sender has selected different currency than the USD.

App version: Play store build v1.5.0
Repro on: Samsung Galaxy s4 mini (4.4.2), Samsung Galaxy J7 Prime (6.0.1), Samsung Galaxy A8+ (8.0.0)
Priority: Low
Testing Account: 310 307 0077/Backup Kay

Repro Steps:

1. Launch the app and sign up in device 1 as User A.
2. Sign up in device 2 as User B
3. Set different currency than the USD for User A.
4. Send Payment request to user B in decimal. for instance 1.65
5. Make sure user B should receive payment request.
6. Observe More than 2 decimal point is shown after payment request amount on “Payment Request” section

Investigation: The issue does not repro when a sender has selected USD as currency.
**Current Behavior: ** More than 2 decimal point is shown after payment request amount on “Payment Request” section
Expected Behavior: 2 decimal points should be shown after payment request amount on “Payment Request” section
Attachment: Android_DecimalIssue.mov (Bug observe at 22 sec)

Improve app experience when Firebase is disabled

Expected Behavior

App works smoothly and error-free without firebase enabled.

Current Behavior

I'm trying to run the android app and use the test faucet page (https://celo.org/build/faucet). The faucet site fails with Unable to faucet - check your address and please try again and funds don't show up in the app.

After battling a bunch of yarn install issues I got the android app running off master but only when disabling Firebase. If I turn on FIREBASE_ENABLED it fails with File google-services.json is missing. The Google Services Plugin cannot function without it. The google-services.json.enc file in the repo seems to only be available to C Labs employees.

Do I need this file (and firebase) in order to use the faucet and the mobile app in general? Pasting my address (which I copied from the settings page in the app, it starts with 0x) into the faucet page causes a websocket on that page to open to firebase and write my faucet request (wss://s-usc1c-nss-245.firebaseio.com/.ws?v=5&ns=celo-faucet), so I'm just sort of assuming the mobile app needs to talk to the same firebase project for the faucet to work

Wallet shouldn't hang if there are no contacts in the address book

Expected Behavior

Importing contacts works if you have no contacts

Current Behavior

Spins indefinitely when you try to import

Scanning QR code from phone camera should link to Valora

On iOS when I put standard camera app on we code it tried to call the number instead of linking to app.

Wallet app should avoid presenting the `Restart` screen when a problem with geth is detected

Expected Behavior

We should be able to clean up geth and restart the node without restarting the app.

Current Behavior

When there's a problem with geth the user is prompted to restart the app to try to fix the problem.

[wallet] App should fail gracefully when the phone it's running out of space

Expected Behavior

App should tell the user the app can't work because they don't have enough space.

Current Behavior

The app reboots with this log (and possibly more I lost):

redux/saga@logger/{"type":"GETH/SET_INIT_STATE","state":"INITIALIZE_ERROR"}

User is not redirected to the “Settings” screen after updating the user name from the “Edit profile” option

Frequency: 100%
** Repro App version:** Celo Integration Wallet build v1.8.2 (39)
Does not repro on: App store build v1.8.0
**Repro on device:**iPhone XS max (13.1), iphone 6+ (12.4.5)

Repro Steps:

1. Launch app and login with tested account
2. Tap on the hamburger menu.
3. Tap on setting option.
4. tap on edit profile option.
5. tap on Edit name
6. Update the username and tap on the return button on Keypad.
7. Observe the user's stay on the Edit name screen.
   Current Behavior: User is not redirected to the “Settings” screen

Expected Behavior: Users should be redirected to the settings screen after updating username.
Impact: Users need to put in manual efforts to see changes.
Attachment: EditNameIssue.mp4 (Bug Observed at 14 sec)

Devs SNBAT check in unused styles

Expected Behavior

A linting rule to check for unused styles. This is not an option in the tslint linter we use, so we would have to use a different linter or find a way to bring in this rule:
https://github.com/Intellicode/eslint-plugin-react-native/blob/master/docs/rules/no-unused-styles.md

Current Behavior

No linting rule to check for unused styles, so there are some unnecessary styles cluttering the mobile codebase

[Android] [Suggestion] App notifications should be shown in one section in the "Notification tray".

App version: Play store build v1.5.0
Repro on: Samsung Galaxy S4 (5.0.1), Samsung j7 prime (6.0.1), Samsung Galaxy A8+ (8.0.0)
Priority: Medium
Testing Account: [phone]/Backup Kay

Repro Steps:

1. install the app and sign up as user 1.
2. Install the app and sign up in user 2.
3. Put the app background from user 1.
4. Send the payment request from user 2 to user 1.
5. Make sure User 1 received the notification.
6. Repeat steps 3 and 4.
7. Observe.

Impact: Bad user experience
Current Behavior: App notifications are shown separately.
Expected Behavior: App notifications should be shown in one section in the "Notification tray".
Attachment: Android_NotificationSection.png

[Stretch] Improve celo-blockchain performance in the wallet

Language selection overlaps with "Connecting..." banner on Welcome onboarding screen

Frequency: 100%
Repro App version: Android Celo internal build 1.9.1, IOS Test flight Celo integration build v1.9.1 (41)
Repro on device: Samsung Galaxy A5 (7.0, iPhone 6 (12.4.7),iPhone 11(14.0)
Precondition: Make sure connecting banner should shown on walk-through screen
Repro Steps:

1. Launch the fresh installed Application
2. Select English language from Select Language screen
3. Tap on English text top right corner and change language to Espanol
4. Make sure user will be redirected back to “Send and receive money instantly” walk-through screen
5. Observe

Current Behavior: “Espanol..” text overlapped with the “Connecting…” banner
Expected Behavior: Text should be displayed without overlapping
Attachment: SelectlanguageTextOverlappingIssue.png

[Wallet] Low end devices crash when scanning QR codes

Expected Behavior

QR scanner in Valora works on any device, or at least had comparable performance to QR scanners in other apps

Current Behavior

QR scanner crashes on low end devices:

https://drive.google.com/file/d/1kDcQXlt4o8N4xEBiREV-ocIRxMcWzqNI/view?usp=sharing

Note that other QR scanners work smoothly for scanning similar data on the same device:

https://drive.google.com/file/d/1ZCbBOwVxWYe3dE8Pc9ks3SJZbGubn6I_/view?usp=sharing

[Wallet] Users SBAT scan QR code with black background

Expected Behavior

Can scan QR code with any background

Current Behavior

Issue with Valora scanning QR code when displayed with a black background. Came up for the QR code used for Jake's band's performance

Devs SBAT easily check for locale strings that are unused

Expected Behavior

Devs should be able to easily check which locale strings are unused. Maybe something like the verify-locales script to check if locale strings are missing in a language.

Current Behavior

Some locale strings are no longer used in the wallet application. To figure out if they're unused, devs need to search each key individually.

'Exchange & Security Fee' is shown as '$0.00' on the 'Buy/Sell Gold Confirmation' screen even though the dollar gets cut with the exchange fee.

Frequency: 100%
App version: iOS Celo Alfajores Wallet Testflight (1.6.0 (21) ), Internal Android Celo Alfa v1.6.0.
Repro on: Google Pixel XL 2 (9.0), Samsung Galaxy A8+ (8.0.0),
Testing Account: 7228953526/backup Key

Repro Steps:

1. Launch the app and login with testing account.
2. Tap on “Gold” tab.
3. Tap on “Buy” gold.
4. Enter amount and tap on “Review” button.
5. Observe Exchange fee shows 0.00.
6. Tap on “Buy # gold” button.
7. Observe Dollars cuts with exchange fee.

Current Behavior: Exchange & Security Fee' is shown as '$0.00'
Impact: User will be confused as amount is cut with exchange fee where as Exchange Fee shows 0 on "Buy/Sell confirmation" screen
Expected Behavior: “Exchange & Security fee” should be shown.
Attachment: Android_exchange fee gets cut but not showning.mp4 (Bug observe at 15 and 1:15 sec)

Devs SBAT use types to represents amounts

Expected Behavior

There should be no ambiguity on how values are represented within the app.

Current Behavior

Currently, amounts are represented with strings and BigNumbers across the codebase. Also, it's not clear whether they are expressed in wei, standard notation, or it's needed to be divided by the smart contract's decimal point.

Need loading state for contact importing on Send screen to avoid “No Contacts Found” being shown while import is in progress

Frequency: 100%
** Repro App version:** Celo integration build v1.8.2 (36)
**Repro on device:**iPhone XS max (13.1), iphone 6+ (12.4.5)
Tested Account: 503 447 5958 / Backup Key

Pre-condition: Application is launch after cold launch the app.

Repro Steps:

1. Launch app and login with tested account
2. Tap on Hamburger menu.
3. Tap on Invite option.
4. Observe.

Current Behavior: “No contact found” screen is shown for while
Expected Behavior: “Fecting contact” should be display if contact are syncing in device

Design: Figma

Attachment: ContactIssue .mp4 (Bug observed at 25 sec)

Refactor/merge `CURRENCY_ENUM` and `LocalCurrencyCode`

Expected Behavior

See below.

Current Behavior

We have 2 similar types for dealing with currencies in the app: CURRENCY_ENUM (Gold and Dollar) and LocalCurrencyCode (USD, EUR, MXN, etc)

There are parts of the code requiring conversions between the two.
It would be nice to have a single currency definition those 2 could build upon / derive from to simplify some of the code dealing with them.