davidkinder / windows-frotz Goto Github PK

I tested Windows-Frotz here with a Linux Mint maschine and it does install and start ok, as well as the installer.exe as the standalone version.

It's also possible to select a game and load it into W-Frotz but after that you can't type in any commands or letters.

Currently, the code uses WM_INPUTLANGCHANGE to detect a change to the language in which text is being input, but the initial input code page is assumed to be the system one (CP_ACP). This might not be true, see
https://stackoverflow.com/questions/1291509/how-to-get-the-code-page-of-the-current-keyboard-layout

(this is copied from https://gitlab.com/DavidGriffith/frotz/-/issues/276, since the Windows Frotz core looks to have the same general code causing the issue)

If print_addr is given the address of a string which starts below 64K but stretches past it, Frotz will segfault.

The issue is that print_addr tells decode_text it's a LOW_STRING, and thus uses a zword to track the address, but since the string goes past 64K, it wraps around and continues decoding from the beginning of memory.

I'm attaching a file which segfaults, as the address wraps around to 0, which ultimately results in a stack overflow as decode_text winds up in an infinite recursive loop.

Whether this is a valid Z-code construct is debatable, but since it can result in a segfault I thought it'd be worth reporting.

See https://intfiction.org/t/z-machine-standard-unclear-aspects-ambiguities/64128/26.

64k.zip

windows 11.
start frotz and open ZSpec11.z6

go to options and change fix width font to cascadia mono.
hit ok
re-open zspec11.z6

pick "3" text styles. fixed width wont show as fixed width.

need to delete
HKEY_CURRENT_USER\Software\David Kinder\Frotz\Display ! Fixed Font Name
then reopen frotz to get a fixed width font back.

Run the Z-code 'abuse' SameGame and note that the display does not line up properly because of font substitution, so we need a better way of handling such cases.

This is closely related to DavidKinder/Windows-Glk#11

I don't know if this is of interest, but I managed to get Windows-Frotz building under appveyor. You can see the details in https://github.com/borg323/Windows-Frotz/tree/appveyor.

I've had two reports of problems with Arthur:

Anyway, in testing Windows Frotz I found I can repeatedly cause the classic Frotz "Store out of dynamic memory" error, by simply clicking through the Arthur intro screens and answering no to the saved game prompt. This occurs just before the first interactive screen with the church and sword and the stone. If I check the ignore internal error option, the game proceeds, but of course may be in some kind of broken state.

and

I just downloaded v1.21 yesterday, and out of pure luck loaded up my copy of Arthur (Release 74 in case it matters). Everything went swimmingly until I typed a command into the game and was returned a 'Call to non-routine' follow by a drop to OS. If I remove the BLB file, this no longer happens. The other V6 games do not suffer this affliction.

I can reproduce neither, and the first reporter indicates that it only happens on one of their two PCs.

Add Russian translation, based on translated .rc file from Nikita Tseykovets:
FrotzRussian_rc.txt

From Nikita:

• Check the correctness of values for the Russian language on line 20 (I was guided by https://docs.microsoft.com/windows/desktop/Intl/language-identifier-constants-and-strings)
• Check the correctness of the encoding on lines 21, 51 and 673 (the standard encoding for the Russian language is windows-1251; may need to change but I'm not sure)
• Check the correctness of language code on line 50 and 672 (I did not understand what it is)
• Check the correctness of language code on line 122 (I did not understand what 1200 means; 0x419 is code of Russian language - https://docs.microsoft.com/windows/desktop/Intl/language-identifier-constants-and-strings)

When multiple calls to @sound_effect are made to be played in one turn, they should be played back to back without any delays. Windows Frotz introduces inconsistent pauses between the end of one play and the next.

An easy way to demonstrate this in action is to blow the whistle on the first turn in Sherlock and then wait. A cab will arrive and a sample of hoofbeats are played back to back three times in ascending volume. If you don't get into the cab, then this happens again in descending volume.

Hello, It seems you have the bug I reported to David Griffith for the Unix Frotz:
https://gitlab.com/DavidGriffith/frotz/issues/84

Taken from https://gitlab.com/DavidGriffith/frotz/-/issues/1:

This was sent in by David Fillmore today:
According to the Z-Machine specification:
"In Version 6, a width field may optionally be given: if this is non-zero, text will then be justified as if it were in the window with that number (if width is positive) or a box -width pixels wide (if negative). Then the table will contain not ordinary text but formatted text: see print_form."
Frotz, on the other hand, tries to get the width of a window of number -width if the value is <= 0, but passes the width value through directly if it is positive. This results in the interpreter crashing with an "Illegal window" error if the width value is less than -7.
Sample Inform6 code tickling this bug:

Switches v6;
Array formatted table 50;

[ main x;
  @output_stream 3 formatted (-30);  ! Frotz treats this as a window number and crashes.
  print "ooh, hello there^boy^how are you";
  @output_stream (-3);
  @print_form formatted;
  @read_char 1 -> x;
];

See also https://intfiction.org/t/output-stream-3-with-width-parameter-causes-interpreter-halt-z6/50659

The function object_address() checks for invalid object references and prints out an error. This should respect the error flags in the interpreter in the same way as runtime_error() does.

(new here, made account to report this, so apologies if doing it incorrectly)

I just started Seastalker Rev 16, 850603. Did the first few commands - enter name, turn on phone, adjust knob, pick up microphone, turn it on, ask bly about problem. Everything was fine so far. Next command was help Bly and it brings up a Frotz Fatal Error "Illegal Attribute" dialog box. Clicking the only choice Ok closes the program completely. Tested and reproduced multiple times. You can even type help Tip (tip is your crewmate) as your first command and it will crash.

Looks like this error goes back a long way. I tried another a different win frotz (not yours) and a dos based frotz and they all crashed the same way.

Issue is not present in the original game. Ran the Masterpiece release with it's normal interpreter under Dosbox-x and help Tip or help Bly just brings up a (said to Tip) How do you want to do that? message.

Steps to reproduce:
Start the game, enter your first and last name, type Help Tip as your first command.

When started the interpreter looks for a Z-code file with the same base name as the executable, but ending in .z5, .z6, .z8 or .zlb. ".zblorb" should be added to that list.

The Bocfel interpreter includes a number of patches to work around problems with various Infocom games. It would be worth including that patch mechanism and any appropriate patches.

Frotz knows internally whether it's playing Sherlock or Lurking Horror: if the sound opcode is called but no sound Blorb files are present, it could bring up a dialog telling the user where to get the files. This dialog should only come up once per loaded game, and have an option to disable it completely.

It seems that the screen width that is written into the Z-machine header (address 0x21) is the actual width % 256. This causes problems for a game or library that tries to adapt the content to the screen width, or judge if the game is even playable.

I can't find anything in the standard saying what the terp should do in this case. Setting the width to 255 may be the best, and most likely to work with existing games.

Attempting to run any of the versions of Trinity found here (https://github.com/historicalsource/trinity) will cause a [Screen too narrow.] or similar message followed by a prompt to press any key to quit, making the game impossible to run. Apparently Trinity requires 79 columns minimum, but I'm getting the error even with no margins on a modern monitor. Not sure what the issue could be.

Hi,
There seems to be a bug in the custom dictionary code when I test it with ziptest.z6. While testing functionality against my own interpreter, M4ZVM, I got very different results while I was comparing the read/input functionality. In particular, WinFrotz doesn't seem to scan an unordered dictionary correctly. My results are on the left with WinFrotz 1.23 on the right (exactly the same behaviour in 1.22). Based on the responses I suspect WinFrotz may need a tweak, but happy to be corrected.

p.s. it seems to already know the words red and blue

I'm totally blind and use the NVDA screen reader. However, Frotz doesn't automatically output text to it unless I use an NVDA add-on. The alternative is using SAPI 5 from the options screen, but this isn't ideal since I can't stop the speech on demand. If possible, please add support for Tolk, so the program can automatically output information to NVDA and other supported screen readers. This would give the user more control over many things, including speech rate, using non-SAPI voices, changing the pronunciation of words, etc. Here's the link to Tolk.
https://github.com/dkager/tolk

See https://gitlab.com/DavidGriffith/frotz/-/issues/226
kellda_print_table.zip

The release notes mention a transcript file. Unfortunately I cannot find such a log file anywhere on my Windows 10 system. Do I have to enable it first?

I'd like to use the transcript file for auto mapping using Trizbort Interactive Fiction Mapper.

Suggestions from Nikita Tseykovets:

• Add a key press to skip the current sentence, and another key to repeat the last sentence. This needs rules to define what constitutes a sentence, but that should be possible.

• Add hotkeys to turn sound on and off, and to control the sound volume, without affecting speech.