GithubHelp home page GithubHelp logo

Comments (4)

mkoval avatar mkoval commented on May 4, 2024

I'm not sure if it makes sense to use the Action machinery here. That is mostly designed to skip ahead in a multi-stage plan and start execution. There are only really two states in this demo, so it seems like overkill. I think we're better off making some more straightforward optimizations, e.g. #13, first.

Did you have something in particular in mind?

from ada_meal_scenario.

siddhss5 avatar siddhss5 commented on May 4, 2024

I see this current version of two states as really a first pass at something that is far more capable and actually has more complicated logic for feeding [e.g. if the person is talking/wants to eat, what food item there is and how to pick each different item, if they want water, if we need to regrasp utensils or clear the table].

Doesn't it seem like switching to Actions now will allow us to both generalize better and grow easier?

from ada_meal_scenario.

mkoval avatar mkoval commented on May 4, 2024

I agree, in theory.

We're still working out the kinks of Action in the Librarian demo. We now have the capability of bypassing steps that we don't want to execute (via BypassableAction), but do not have a convenient way of parallelizing planning and execution. I think we should finish working out the details in that demo---and maybe move the base classes to PrPy---before porting the code over here, too.

@jeking04 What do you think?

from ada_meal_scenario.

Stefanos19 avatar Stefanos19 commented on May 4, 2024

I believe this has been solved with the merging of Jen's branch:
1a8a4cc

from ada_meal_scenario.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.