GithubHelp home page GithubHelp logo

Comments (6)

Mattie112 avatar Mattie112 commented on June 23, 2024 1

Thanks, I will update to the latest version and confirm that it works. Thans for adding the test/build config, did not notice that :)

from twofactorauth.

Mattie112 avatar Mattie112 commented on June 23, 2024 1

Yes, all seem to be working fine (with Endroid v5).

Great timing btw, I was just about to merge my internal MR but now I can set it back to this repo instead of my own fork :)

Thanks again!

from twofactorauth.

willpower232 avatar willpower232 commented on June 23, 2024

I guess this line doesn't work for version 5 then?

$this->endroid4 = method_exists(QrCode::class, 'create');

Definitely open to PRs on this one.

from twofactorauth.

Mattie112 avatar Mattie112 commented on June 23, 2024

I will try to see if that is the only problem and then create a PR for this! if it is more work I dont have time right now and I will report back.

from twofactorauth.

Mattie112 avatar Mattie112 commented on June 23, 2024

This should fix it: #115

Don't currently have the time to test it with other versions then 4 and 5.

from twofactorauth.

willpower232 avatar willpower232 commented on June 23, 2024

@Mattie112 thanks for the PR and the patience for me to sort it out, feel free to close if everything is working as intended for you now

from twofactorauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.