Slimming down the lib further about twofactorauth

[willpower232]

while you're at it, might be worth cleaning up all the unreachable code in codeEquals as hash_equals is PHP >= 5.6 so definitely always exists

[willpower232]

wait till they announce it as a native library or something haha

[RobThree]

This is a leftover from the PHP5 era I guess. I don't mind if the openssl & hash ones get trashed. We stopped supporting PHP5 long ago. I would like to keep the interface because some people may be using their own implementations (I can see people using a hardware RNG for example).

[RobThree]

Dangit! I was removing them too, you beat me to it (and did a better job).

👊

(Editted because I drag & dropped the wrong screenshot 🤪 I'm an idiot 🤦 )

[NicolasCARPi]

@willpower232 done, good spot!

When I'm done with this lib it'll be a 3 lines function :p

[NicolasCARPi]

@RobThree See #122 then. And yes, users can still swap out the rngprovider for their own, if they need to.