Comments (12)
that is a fair point, as attributes became a thing in 8.0, this would presumably generate an error rather than being ignored as a comment in earlier versions
also it looks like PHP 8.1 might get another year of support so this might have to thoroughly get stuck on the back burner
from twofactorauth.
they will be forced to upgrade first before they can use the newer version, right?
No. We'll emit a bugfix on the 8.1 supported branch.
from twofactorauth.
So:
public function getQRCodeImageAsDataUri(string $label, #[\SensitiveParameter] string $secret, int $size = 200): string
from twofactorauth.
good idea, would you like to make a PR?
from twofactorauth.
Note that this is only available in PHP 8.2. I'm not sure it's worth adding while we still support 8.1. It seems to be harmless, but might have side effects in static analysis for instance. Otherwise I'm all for it, of course!
PHP 8.1 end of security support is in 7 months, active support ended 4 months ago, so we could even go forward and require 8.2 along with this change. Users of PHP 8.1 will simply not update this library, and should already start planning upgrading their PHP version.
from twofactorauth.
so this might have to thoroughly get stuck on the back burner
Given the stable state of this library (we don't commit bugfixes every day), going with it earlier is no issue. I've recently (6 hours ago) upgraded my app to use PHP 8.3, so I would benefit from this change. Users stuck on 8.1 will simply continue using the current version, until they upgrade, and then they'll already have a fresh version with this change waiting for them!
from twofactorauth.
Users stuck on 8.1 will simply continue using the current version
But if we change/fix something they will be forced to upgrade first before they can use the newer version, right? And since 8.1 might get another year of support I guess we have to consider if the attribute is worth it.
Having said that it does look like a cool feature. And should any issues arise we can always backport to the attribute-less version, right?
from twofactorauth.
That's what I meant with "And should any issues arise we can always backport to the attribute-less version, right?"
from twofactorauth.
Yeah sorry I didn't understand correctly the second sentence, but yeah.
from twofactorauth.
PR opened #119
from twofactorauth.
As #119 has been merged, this issue should be closed as resolved.
from twofactorauth.
Yeah we'd probably forget to close when v3 is actually released
from twofactorauth.
Related Issues (20)
- QR Code Expiring HOT 2
- Security Risk: using `QRServerProvider` as default provider HOT 15
- CodeIgniter 4 Integration HOT 2
- QR Code doesn't work with Dashlane HOT 12
- Incompatible with endroid/qr-code > 5.0.0 HOT 6
- Slimming down the lib further HOT 6
- getQRCodeImage(): Return value must be of type string, bool returned HOT 2
- minimal version HOT 2
- Fatal error: Uncaught Error: Class 'RobThree\Auth\Providers\Rng\CSRNGProvider' not found HOT 2
- Fatal error: Uncaught Error: Call to undefined function RobThree\Auth\Providers\Time\socket_create() HOT 4
- 2fa HOT 1
- Google / MS Authenticator HOT 10
- endroid/qr-code compatibility issue HOT 1
- Newly generated secrets failing to verify codes HOT 13
- How i can generate Backup 2fa after user has been activated 2fa HOT 5
- Deprecation warning in PHP8 HOT 6
- Version mismatch HOT 6
- Account name in MS Authenticator HOT 18
- How to migrate to new server HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twofactorauth.