getQRCodeImage(): Return value must be of type string, bool returned about twofactorauth

[NicolasCARPi]

Yeah, handling curl errors in this basehttp class seems the right way to go. And then it can only return string or throw exception. I guess it can simply be something like:

 $data = curl_exec($curlhandle);
if ($data === false) {
     throw new WhateverException(curl_error($curlhandle));
}

[willpower232]

If you aren't specifying the QR code provider then it will be using the default QRServerProvider so I imagine that there was a curl error between yourselves and api.qrserver.com, unfortunately the code should be handling it better but isn't.

You might wish to switch to an offline QR code provider like Bacon or Endroid.

@NicolasCARPi @RobThree I presume the best fix is for getContent to throw an exception if it gets a bool back from curl rather than forcing the other four providers to throw their own exceptions?

The migration path to V3 isn't super advanced so I have no issue with not backporting the fix to V2 unless you really want to maintain a V2 branch at this point now that the V3 changes are in the primary branch.