GithubHelp home page GithubHelp logo

minimal version about twofactorauth HOT 2 CLOSED

f1-outsourcing avatar f1-outsourcing commented on June 20, 2024 2
minimal version

from twofactorauth.

Comments (2)

RobThree avatar RobThree commented on June 20, 2024 2

If you don't like it you don't have to use it. I don't mind criticism or constructive feedback but your approach isn't very pleasant to put it mildly. And that's coming from a Dutch guy which are known for being blunt. PR's are welcome.

When I was browsing your files I see also things like time.google.com

Which is optional an can be changed to anything. You don't have to use the provided defaults / implementations.

from twofactorauth.

NicolasCARPi avatar NicolasCARPi commented on June 20, 2024 1

Hello,

Version 3.x (currently the master branch) adresses these issues you mention. In v3, one needs to explicitely define a QRCodeProvider.

You can use Endroid or Bacon, or anything else, as long as the interface works (I'm using Mpdf QR code generator in my project). These work perfectly in air-gapped systems.

We're in the process of releasing v3.

But all these files for simple qr code generation and auth seems a bit over done.

A lot of my recent contributions removed some code, and streamlined the library. For instance, this PR #122.

As a final note, please realize that your message is quite negative and out of place. This library is provided to you free of charge, and while we welcome constructive criticism, your message is too blunt. Look at how you could have expressed the same thing but with respect: #104.

from twofactorauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.