Comments (2)
If you don't like it you don't have to use it. I don't mind criticism or constructive feedback but your approach isn't very pleasant to put it mildly. And that's coming from a Dutch guy which are known for being blunt. PR's are welcome.
When I was browsing your files I see also things like time.google.com
Which is optional an can be changed to anything. You don't have to use the provided defaults / implementations.
from twofactorauth.
Hello,
Version 3.x (currently the master
branch) adresses these issues you mention. In v3, one needs to explicitely define a QRCodeProvider.
You can use Endroid or Bacon, or anything else, as long as the interface works (I'm using Mpdf QR code generator in my project). These work perfectly in air-gapped systems.
We're in the process of releasing v3.
But all these files for simple qr code generation and auth seems a bit over done.
A lot of my recent contributions removed some code, and streamlined the library. For instance, this PR #122.
As a final note, please realize that your message is quite negative and out of place. This library is provided to you free of charge, and while we welcome constructive criticism, your message is too blunt. Look at how you could have expressed the same thing but with respect: #104.
from twofactorauth.
Related Issues (20)
- QR Code Expiring HOT 2
- Security Risk: using `QRServerProvider` as default provider HOT 15
- CodeIgniter 4 Integration HOT 2
- QR Code doesn't work with Dashlane HOT 12
- Incompatible with endroid/qr-code > 5.0.0 HOT 6
- Use SensitiveParameter class HOT 12
- Slimming down the lib further HOT 6
- getQRCodeImage(): Return value must be of type string, bool returned HOT 2
- Fatal error: Uncaught Error: Class 'RobThree\Auth\Providers\Rng\CSRNGProvider' not found HOT 2
- Fatal error: Uncaught Error: Call to undefined function RobThree\Auth\Providers\Time\socket_create() HOT 4
- 2fa HOT 1
- Google / MS Authenticator HOT 10
- endroid/qr-code compatibility issue HOT 1
- Newly generated secrets failing to verify codes HOT 13
- How i can generate Backup 2fa after user has been activated 2fa HOT 5
- Deprecation warning in PHP8 HOT 6
- Version mismatch HOT 6
- Account name in MS Authenticator HOT 18
- How to migrate to new server HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twofactorauth.