GithubHelp home page GithubHelp logo

Comments (6)

VictorLamoine avatar VictorLamoine commented on June 1, 2024

If it still builds on Travis, then I'm pretty sure it's safe to remove it :)

from industrial_calibration.

RyodoTanaka avatar RyodoTanaka commented on June 1, 2024

I removed camera_aravis dependence at PR #83 .

from industrial_calibration.

gavanderhoorn avatar gavanderhoorn commented on June 1, 2024

camera_aravis was/is used in some of the launch files. The fact that Travis doesn't fail the build when you remove the dependency doesn't really mean much, unless the CI build also runs some roslaunch tests (which afaik, it doesn't).

@drchrislewis should know whether the aravis dependency is still needed / wanted.

from industrial_calibration.

VictorLamoine avatar VictorLamoine commented on June 1, 2024

Ah right, I just disabled the tests!

from industrial_calibration.

drchrislewis avatar drchrislewis commented on June 1, 2024

camera_aravis is only required to run the launch files. We should remove it from the package.xml
I use it for working with Basler cameras. You can get a version that works on indigo from
https://github.com/drchrislewis/camera_aravis.git
It is forked from takiaine/camera_aravis, with a couple of minor changes. There are at least three different camera_aravis stacks out there, none of which work for me without some edits. I've had a pull request in for some time, but no response, so perhaps its a stale stack.
Please let me know if you have any questions in using the calibration stacks.

from industrial_calibration.

RyodoTanaka avatar RyodoTanaka commented on June 1, 2024

@VictorLamoine @drchrislewis

Ah, I understand.
Thank you for your advice.

from industrial_calibration.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.