GithubHelp home page GithubHelp logo

tf2 tutorials outdated about geometry2 HOT 17 CLOSED

ros avatar ros commented on July 1, 2024
tf2 tutorials outdated

from geometry2.

Comments (17)

tfoote avatar tfoote commented on July 1, 2024

Things I've found that need to be updated. turtlesim::Velocity deprecated/removed

several things moved into tf2_ros such as transform_listener.

from geometry2.

bricerebsamen avatar bricerebsamen commented on July 1, 2024

I agree with tkruse. And #20. Given the state of the documentation and so on, it appears that tf2 is not mature yet, so I will wait before migrating.

from geometry2.

jonbinney avatar jonbinney commented on July 1, 2024

The python tutorials are also very outdated. Just tried using them and wasn't able to get anything working. For example, they seem to assume that the TransformListener is in tf2, although it has moved to tf2_ros:

http://wiki.ros.org/tf2/Tutorials/Writing%20a%20tf2%20listener%20%28Python%29

from geometry2.

airballking avatar airballking commented on July 1, 2024

Related question: I looked at the tf2-version of the time travel tutorial:

http://wiki.ros.org/tf2/Tutorials/tf2%20and%20time%20%28C%2B%2B%29

It uses a tf2_ros::TransformListener::waitForTransform(...). Looking at the code in the repo, I cannot find a waitForTransform function. In fact, I just cloned the entire repo and recursively grepped for waitForTransform --nothing.

Is waitForTransform(...) a deprecated feature under tf2 or is this particular tutorial outdated or am I overlooking something in the code?

from geometry2.

vrabaud avatar vrabaud commented on July 1, 2024

Even more critical, some files do not exist anymore (and I therefore could not fix the tutorial myself):
http://wiki.ros.org/tf2/Tutorials/Writing%20a%20tf2%20broadcaster%20%28C%2B%2B%29
refers to trunk_cturtle/stacks/ros_pkg_tutorials/turtle_tf2/src/turtle_tf2_broadcaster.cpp

from geometry2.

trainman419 avatar trainman419 commented on July 1, 2024

+1; I ran into missing files for tf2 as well.

from geometry2.

trainman419 avatar trainman419 commented on July 1, 2024

This has also been asked on ROS answers, and remains sadly unanswered: http://answers.ros.org/question/123336/where-is-tf2_echo-and-turtle_tf2/

from geometry2.

destogl avatar destogl commented on July 1, 2024

Hello all,

yesterday I finally managed to lookup transforms with tf2. I also posted my way on the answers.ros.org.

Is this way how should be done in tf2? What I do not understand is why isn't there tf2_ros::TransformListener::lookupTransform() method? Should be really done directly with buffer?

I would like to put a bit effort and time to correct general tutorials on http://www.ros.org/wiki/tf2/Tutorials , but before would like to check if my way is correct.

Thanks!

from geometry2.

trainman419 avatar trainman419 commented on July 1, 2024

Confirmed; that's the correct way to use tf2.

Having the buffer separate from the transformListener is advantageous in some applications, where there may not be a listener, such as when reading transforms from bag files, or when using tf2 as a standalone transform library inside a larger application.

from geometry2.

destogl avatar destogl commented on July 1, 2024

Ok, but wouldn't be reasonable, to preserve "compatibility" to tf, put also lookupTransform method into tr2_ros::TransformListener, which will than call underlying function from buffer?

from geometry2.

tfoote avatar tfoote commented on July 1, 2024

tf2 is a new clean API. The point of changing the namespace is to allow us to clean up the API. If you want to use the tf API it's still available for compatibility. (It uses tf2 under the hood)

from geometry2.

destogl avatar destogl commented on July 1, 2024

Hi again... I just created, or better say migrated, turtle_tf tutorial to turtle_tf2 tutorial. As soon as the issue is solved they will be geometry_tutorials package. Now would be great if somebody has time to start rewriting tutorial pages, since I am not sure if I manage in the next few weeks.

from geometry2.

davetcoleman avatar davetcoleman commented on July 1, 2024

+1 I just ran into these missing tutorials as well

from geometry2.

tfoote avatar tfoote commented on July 1, 2024

Thanks to the work of @shokoofeh in geometry_tutorials most of the tf2 tutorials have been filled out. I've walked through the c++ tutorials at: http://wiki.ros.org/tf2/Tutorials I still have the python tutorials to verify.

from geometry2.

tfoote avatar tfoote commented on July 1, 2024

I walked through all the python tf2 tutorials yesterday. They can now be followed.

from geometry2.

davetcoleman avatar davetcoleman commented on July 1, 2024

Awesome, thanks!

from geometry2.

AmaurX avatar AmaurX commented on July 1, 2024

@tfoote I think there are still some problems with the cpp tf2 tutorials.
waitForTransform doesn't appear to exist, and some part of codes don't add up between tutorials... I've managed to make it work any way, I may go and change it in the tutorials

from geometry2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.