Comments (6)
yes, I will add this after writing the fuzzing prototype
from manifold.
Thanks, I managed to simplify your first repro yesterday and I see where the problem is. Hopefully I'll have it fixed soon.
from manifold.
Thanks! Would you like to add this to mest_test
? We can just put DISABLED_
in front of the name so the CI passes until we manage to debug it.
from manifold.
Did some debugging with this (learning to use rr), it seems that current
becomes -1
after executing line 248, and then just produce a cycle of 1, 37, 11, 18, 67, 21
. I guess -1
means that the edge should be removed?
manifold/manifold/src/edge_op.cpp
Lines 245 to 249 in fadad77
from manifold.
Thanks! I'd say -1
generally means something went wrong (it should probably be asserted, ideally). I'll take a look; I usually have to draw out the topology on paper to figure out where my bad assumption is.
from manifold.
it seems that the following change to master will also trigger this bug for Samples.Frame
test:
diff --git a/manifold/src/impl.cpp b/manifold/src/impl.cpp
index 9b5513b..ea91a60 100644
--- a/manifold/src/impl.cpp
+++ b/manifold/src/impl.cpp
@@ -134,7 +134,7 @@ struct SwapHalfedges {
Halfedge* halfedges;
const TmpEdge* edges;
- __host__ void operator()(int k) {
+ __host__ __device__ void operator()(int k) {
const int i = 2 * k;
const int j = i - 2;
const TmpEdge thisEdge = edges[i];
@@ -519,10 +519,10 @@ void Manifold::Impl::CreateAndFixHalfedges(const VecDH<glm::ivec3>& triVerts) {
// and fix it by swapping one of the identical edges, so it is important that
// we have the edges paired according to their face.
thrust::stable_sort(thrust::device, edge.begin(), edge.end());
- thrust::for_each_n(thrust::host, countAt(0), halfedge_.size() / 2,
- LinkHalfedges({halfedge_.ptrH(), edge.cptrH()}));
- thrust::for_each(thrust::host, countAt(1), countAt(halfedge_.size() / 2),
- SwapHalfedges({halfedge_.ptrH(), edge.cptrH()}));
+ thrust::for_each_n(thrust::device, countAt(0), halfedge_.size() / 2,
+ LinkHalfedges({halfedge_.ptrD(), edge.cptrD()}));
+ thrust::for_each(thrust::device, countAt(1), countAt(halfedge_.size() / 2),
+ SwapHalfedges({halfedge_.ptrD(), edge.cptrD()}));
}
from manifold.
Related Issues (20)
- Is Manifold CAD opensource? HOT 2
- #528 causes invalid `UpdateVert` calls HOT 31
- Refactor triangulator HOT 2
- triangulator bugs related to #528
- vertProperties behavior HOT 3
- refactor SparseIndices to use HashTable HOT 1
- allow double precision HOT 14
- Python Interface Vertex and Face Types HOT 5
- Volume calculation is not deterministic HOT 12
- Testing booleans of meshes HOT 2
- Emscripten build HOT 10
- Lost faces when creating manifold HOT 22
- Subtraction creates overlapping triangles HOT 6
- extrude twist can cause invalid geometry HOT 5
- XCode 15 Link problem with <memory_resource> HOT 6
- How could I create a manifold object for a simple rectangle? HOT 4
- non-manifold mesh repair HOT 1
- refine to length HOT 6
- Support for OS X 10.13? HOT 4
- Wrong vertex normals and uvs after boolean subtraction HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from manifold.