kai-46 / colmapforvissat Goto Github PK

Describe the bug
I tried to build this software in Windows with Visual Studio 2017 and 2019, and CUDA_TOOLKIT= 9.2,10.2,11.2.
But colmap_cuda cannot be built successfully.

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

• OS: Window10
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
I'm not sure if this is a bug or just a platform dependent behaviour, but the array named pose_host_data[kNumTformParams * problem_.src_image_idxs.size()] defined in patch_match_cuda.cu @ line #1734 results in the follwing error:
this cannot be used in a constant expression.
I was able to mitigate the error and successfully build the project by allocating the array on heap and memset-ing the required umber of bytes as follows:

float* poses_host_data = new float[kNumTformParams * problem_.src_image_idxs.size()];
for (size_t i = 0; i < kNumTformParams * problem_.src_image_idxs.size(); i++) {
    poses_host_data[i] = 0.0;
  }
....
....
delete []poses_host_data;

Requesting your help in verifying the correctness of this patch.

To Reproduce
Steps to reproduce the behavior:
Just followed typical cmake build steps using Visual Studio 2019.

Expected behavior
NA
Screenshots
NA
Desktop (please complete the following information):

• OS: Windows 10 64bit

Additional context
Add any other context about the problem here.