janghunhyeon / pcloc Goto Github PK

Hi,

Thanks for the work. Can you please share the link to your research paper? I am not able to find it on arxiv.

Usage of arg parser for --opt_div_matching is wrong in the code.

It's a string which always evaluates to True here irrespective of keyword provided, will only evaluate to False if the argument is empty. Rewrite it to something like below code:

parser.add_argument('--my-flag',choices=('True','False'))
arguments = parser.parse_args()
MyFlag = arguments.my_flag == 'True'

instead of

parser.add_argument('--opt_div_matching', default=True, help='True: Divided matching, False: base matching')
if args.opt_div_matching:
    refinement = Refinement_extended(superglue)
else:
    refinement = Refinement_base(superglue)

Source

Hi,

Very excited to see your great work on indoor relocalization. I wonder when will you release the code?

Thanks a lot for your attention.

where is the code