strands-project / fremen Goto Github PK

see https://lcas.lincoln.ac.uk/jenkins/job/devel-hydro-fremen/ARCH_PARAM=amd64,UBUNTU_PARAM=precise,label=devel/5/console

before we engage in further releasing adventure, let's try to get the devel build to succeed ;-)

@hkaraoguz will send @Jailander a SOMA ecample to see how we can explode and connect his with Frongo

This is just a suggestion, I came to notice that a lot of the code in the three FreMEn package is actually shared, but exists three time (e.g. CFrelement.cpp). Wouldn't it be a good idea to refactor the shared code into a shared library?

I see lots of the following when running with the mdp nodes which talk to frenap:

[ERROR] [1427404235.046518000]: Service call failed: service [/message_store/query_messages] responded with an error: error processing request: 'edge_id'

Mongo also isn't happy:

['Traceback (most recent call last):\n', '  File "/opt/ros/indigo/lib/python2.7/site-packages/rospy/impl/tcpros_service.py", line 623, in _handle_request\n    response = convert_return_to_response(self.handler(request), self.response_class)\n', '  File "/opt/ros/indigo/lib/mongodb_store/message_store_node.py", line 213, in query_messages_ros_srv\n    message = dc_util.dictionary_to_message(entry, cls)\n', '  File "/opt/ros/indigo/lib/python2.7/site-packages/mongodb_store/util.py", line 314, in dictionary_to_message\n    fill_message(message, dictionary)\n', '  File "/opt/ros/indigo/lib/python2.7/site-packages/mongodb_store/util.py", line 265, in fill_message\n    value = document[slot]\n', "KeyError: 'edge_id'\n"]

Therefore the Ubuntu package doesn't have anything to run.

Just for convenience, could this repo get a meta package which is added to one of the more general packages in metapackages?

I would like to use fremen for our project (maybe) and noticed that when trying to build it, it depends on strands_navigation_msgs. Which means that if I want to build things from source, I have to check out the whole navigation stuff as well including all its dependencies which I don't need.

Of course, once there are packages for Kinetic one could install those and be done with it, but I am not sure I can convince everybody to set-up the strands repositories on their machines. Hence, it would be easiest if this otherwise very self-contained repo would not depend on strands_navigation_msgs. As far as I can tell, only frenap depends on those which also creates circular dependencies between the repos as discussed in #13.

If it is not too much of a problem, I would suggest moving frenap to strands_navigation instead. This would solve the circular dependencies issue as far as I can see and would also mean that this repo only relies on officially released packages. Also, I am not sure if frenap is supposed to be used without strands_navigation in the first place.

All this is, of course, just a suggestion so please ignore me if it is too much work or you disagree. The workaround is just deleting frenap from my local fork so not much of a problem. Just thought I'd share my two cents.

https://lcas.lincoln.ac.uk/jenkins/job/ros-indigo-fremen2dgrid_binarydeb_trusty_amd64/1/console

CMake Error at /opt/ros/indigo/share/catkin/cmake/catkinConfig.cmake:75 (find_package):
  Could not find a package configuration file provided by "nav_msgs" with any
  of the following names:

    nav_msgsConfig.cmake
    nav_msgs-config.cmake

  Add the installation prefix of "nav_msgs" to CMAKE_PREFIX_PATH or set
  "nav_msgs_DIR" to a directory containing one of the above files.  If
  "nav_msgs" provides a separate development package or SDK, be sure it has
  been installed.

@gestom I had to rename the repository as the mix of lower case writing in the rosdistro file and the name actually being sort of camel-cased caused a lot of problems. I think it's our general convention to name repos lower case only. I hope this is ok. If not, we need to find another solution. This was the problem that caused the failing of of automated triggers on jenkins.

Please close this ticket as soon as you have taken notice of it.

the release packages as they are now will all be empty, because the CMakeLists.txt in the packages don't install anything. Only things that are installed are also released! Please make sure that after a catkin_make install you find all the files you expect in $CATKIN_WORKSPACE/install. I suggest testing this locally, e.g. by running source $CATKIN_WORKSPACE/install/setup.bash (not devel!) and see if you can run the software.

FremenServer should take floating point values between 0 and 1 for its states instead of booleans or another option for this to be possible.
https://github.com/strands-project/fremen/blob/master/FremenServer/action/Fremen.action#L22

We wanted to have have a webpage to test the functionality of Frongo. @marc-hanheide committed to this TG.

as discussed in strands-project/strands_navigation#215

Will there be a version to be released any time soon? I'd like one to be there before Leeds...

There is a big issue, currently stopping mongodb_store from being released for Kinetic. See the discussion at strands-project/mongodb_store#185

It boils down to the C++ MongoClient API being completely refactored and not working with the old code anymore. Here, frenap seems to be the only component that actually relies on mongoclientcxx and mongodb_store. Some other packages declare they would depend on mongodb_store, but I don't think they actually do. If they just need the Python Mongo bindings they should depend on python-pymongo instead. Please check and try to make this work on Kinetic. The build farm is set up to run pull request builds on Kinetic.